Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module Deployment Inconsistent Between Projects #399

Open
samiamseid opened this issue Feb 22, 2024 · 5 comments
Open

Module Deployment Inconsistent Between Projects #399

samiamseid opened this issue Feb 22, 2024 · 5 comments
Assignees
Labels
issue type: metric update updates of existing metrics, plots or thresholds

Comments

@samiamseid
Copy link
Collaborator

** Metric / Plot Impacted **
Different projects are supposed to have different modules depending on project needs (for example, only behavior projects need the behavior modules). However, currently there are key modules that belong in every project that are not consistently deployed across projects.

For example, LearningmFISHTask1A has "[Brain Health and Window Clarity]" but U01BFCT does not. I think we need to review all active projects and current modules and make sure the correct modules are being used.

Update Motivation
A. We are currently missing important QC metrics in certain projects
B. QC may not be consistent between projects if different versions of metrics are being deployed
C. Analysis of historical QC values is less valid if certain projects are missing metrics

Requested Feature/Solution
Review modules in active projects and make sure we are consistent

@samiamseid samiamseid added the issue type: metric update updates of existing metrics, plots or thresholds label Feb 22, 2024
@seanmcculloch seanmcculloch self-assigned this Feb 27, 2024
@DowntonCrabby
Copy link
Collaborator

In the case of missing the brain health and window clarity module- I have updated this in the dev instanced of the database:
image

Here are the modules currently:
image

@samiamseid
Copy link
Collaborator Author

I can confirm that these modules look correct as you have them listed!
However, i notice that all of the sessions running active behavior are currently marked as "error" in dev-QC, and are missing behavior, task, and lick modules (though the session report itself does not say they are missing)

@DowntonCrabby
Copy link
Collaborator

Can you add a screenshot of this, Sam?

@samiamseid
Copy link
Collaborator Author

devqc
devqc2

@samiamseid
Copy link
Collaborator Author

I just checked on some dev qc reports that generated back in mid may, and it looks like whatever was causing the issue i mentioned above is gone. Both active and passive project reports have the all the necessary modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue type: metric update updates of existing metrics, plots or thresholds
Projects
None yet
Development

No branches or pull requests

3 participants