Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qc module status change if metrics and/or plots missing #369

Open
DowntonCrabby opened this issue Dec 11, 2023 · 2 comments
Open

qc module status change if metrics and/or plots missing #369

DowntonCrabby opened this issue Dec 11, 2023 · 2 comments
Assignees
Labels
software: mouse-seeks related specifically to mouse-seeks

Comments

@DowntonCrabby
Copy link
Collaborator

Describe the bug
The QC system currently provides a list of missing plots and metrics, however other critical information is not present. For example, can something be reprocessed to get the missing metrics? How do operators QC if metrics are missing?

Expected behavior
Missing metrics and plots should be treated in the same way as when thresholds are violated- it should have an impact on the qc status of the module- and it should also be looked into as to why the metrics & plots are missing.

Scope
This relates to all reports.

@DowntonCrabby DowntonCrabby added the software: mouse-seeks related specifically to mouse-seeks label Dec 11, 2023
@seanmcculloch seanmcculloch added this to the MouseQC Q1 Priorities milestone Jan 30, 2024
@samiamseid
Copy link
Collaborator

Something causing this feature to duplicate the fail tag multiple times a second
duplication

@samiamseid
Copy link
Collaborator

Tested on session http://qc-sys-webapp-dev/qc/ophys/session/1346243082 and experiment http://qc-sys-webapp-dev/qc/ophys/session/1346243082

"Pass" could not be selected if metric is missing (this seems to be working as intended)
QC verdict in session summary and in session log both accurately reflect failed status even if all other modules are marked passed (working as intended)

This feature looks ready to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
software: mouse-seeks related specifically to mouse-seeks
Projects
None yet
Development

No branches or pull requests

3 participants