-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adaptive supra bugs out #2129
Comments
From QN24.26.009.20.07A.03.nwb:
In b5300a3 (PSQ_DS_GatherAndWriteFrequencyToLabnotebook: Don't calculate apfrequency with failing baseline QC, 2024-05-02) we skipped calculating the ap frequency if the baseline QC is failing. But this hurts us later in PSQ_DS_GatherOvershootCorrection as we then realize that we have a different number of dascale values compared to the apfrequency values. |
@t-b, should we only record DA scale values when sweeps pass QC? |
We always gather the DA scale value in the labnotebook. This is independent of the analysis functions. I guess the needed change is to gather APFreq and DAscale value only for passing sweeps. |
Observations:
|
The first analysis was wrong. The issue was that the currently displayed sweeps were changed but we assumed that it was not. |
Ever since the creation of the function in fab0fcf (PSQ_GetSweepFormulaResult: Extract out helper function, 2022-02-22) we check that the requested sweep is one of the displayed sweeps. But that does not make sense as the user might change currently displayed sweeps. So instead we now don't check the sweep number, this requires that the last store is the one which we want to query. This is the case for all current function calls of PSQ_ExecuteSweepFormula/PSQ_GetSweepFormulaResult/PSQ_GetSweepFormulaResultWave. Close #2129
Ever since the creation of the function in fab0fcf (PSQ_GetSweepFormulaResult: Extract out helper function, 2022-02-22) we check that the requested sweep is one of the displayed sweeps. But that does not make sense as the user might change currently displayed sweeps. So instead we now don't check the sweep number, this requires that the last store is the one which we want to query. This is the case for all current function calls of PSQ_ExecuteSweepFormula/PSQ_GetSweepFormulaResult/PSQ_GetSweepFormulaResultWave. Close #2129
Ever since the creation of the function in fab0fcf (PSQ_GetSweepFormulaResult: Extract out helper function, 2022-02-22) we check that the requested sweep is one of the displayed sweeps. But that does not make sense as the user might change currently displayed sweeps. So instead we now don't check the sweep number, this requires that the last store is the one which we want to query. This is the case for all current function calls of PSQ_ExecuteSweepFormula/PSQ_GetSweepFormulaResult/PSQ_GetSweepFormulaResultWave. Close #2129
Ever since the creation of the function in fab0fcf (PSQ_GetSweepFormulaResult: Extract out helper function, 2022-02-22) we check that the requested sweep is one of the displayed sweeps. But that does not make sense as the user might change currently displayed sweeps. So instead we now don't check the sweep number, this requires that the last store is the one which we want to query. This is the case for all current function calls of PSQ_ExecuteSweepFormula/PSQ_GetSweepFormulaResult/PSQ_GetSweepFormulaResultWave. Close #2129
Ever since the creation of the function in fab0fcf (PSQ_GetSweepFormulaResult: Extract out helper function, 2022-02-22) we check that the requested sweep is one of the displayed sweeps. But that does not make sense as the user might change currently displayed sweeps. So instead we now don't check the sweep number, this requires that the last store is the one which we want to query. This is the case for all current function calls of PSQ_ExecuteSweepFormula/PSQ_GetSweepFormulaResult/PSQ_GetSweepFormulaResultWave. Close #2129
Ever since the creation of the function in fab0fcf (PSQ_GetSweepFormulaResult: Extract out helper function, 2022-02-22) we check that the requested sweep is one of the displayed sweeps. But that does not make sense as the user might change currently displayed sweeps. So instead we now don't check the sweep number, this requires that the last store is the one which we want to query. This is the case for all current function calls of PSQ_ExecuteSweepFormula/PSQ_GetSweepFormulaResult/PSQ_GetSweepFormulaResultWave. Close #2129
Ever since the creation of the function in fab0fcf (PSQ_GetSweepFormulaResult: Extract out helper function, 2022-02-22) we check that the requested sweep is one of the displayed sweeps. But that does not make sense as the user might change currently displayed sweeps. So instead we now don't check the sweep number, this requires that the last store is the one which we want to query. This is the case for all current function calls of PSQ_ExecuteSweepFormula/PSQ_GetSweepFormulaResult/PSQ_GetSweepFormulaResultWave. Close #2129
Ever since the creation of the function in fab0fcf (PSQ_GetSweepFormulaResult: Extract out helper function, 2022-02-22) we check that the requested sweep is one of the displayed sweeps. But that does not make sense as the user might change currently displayed sweeps. So instead we now don't check the sweep number, this requires that the last store is the one which we want to query. This is the case for all current function calls of PSQ_ExecuteSweepFormula/PSQ_GetSweepFormulaResult/PSQ_GetSweepFormulaResultWave. Close #2129
Ever since the creation of the function in fab0fcf (PSQ_GetSweepFormulaResult: Extract out helper function, 2022-02-22) we check that the requested sweep is one of the displayed sweeps. But that does not make sense as the user might change currently displayed sweeps. So instead we now don't check the sweep number, this requires that the last store is the one which we want to query. This is the case for all current function calls of PSQ_ExecuteSweepFormula/PSQ_GetSweepFormulaResult/PSQ_GetSweepFormulaResultWave. Close #2129
Ever since the creation of the function in fab0fcf (PSQ_GetSweepFormulaResult: Extract out helper function, 2022-02-22) we check that the requested sweep is one of the displayed sweeps. But that does not make sense as the user might change currently displayed sweeps. So instead we now don't check the sweep number, this requires that the last store is the one which we want to query. This is the case for all current function calls of PSQ_ExecuteSweepFormula/PSQ_GetSweepFormulaResult/PSQ_GetSweepFormulaResultWave. Close #2129
Ever since the creation of the function in fab0fcf (PSQ_GetSweepFormulaResult: Extract out helper function, 2022-02-22) we check that the requested sweep is one of the displayed sweeps. But that does not make sense as the user might change currently displayed sweeps. So instead we now don't check the sweep number, this requires that the last store is the one which we want to query. This is the case for all current function calls of PSQ_ExecuteSweepFormula/PSQ_GetSweepFormulaResult/PSQ_GetSweepFormulaResultWave. Close #2129
Link: https://aiephys.slack.com/archives/C06P3MYEV6H/p1716920346361379
The text was updated successfully, but these errors were encountered: