New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codegn: Code Clenup Ideas and Plans #375

Open

4 of 5 tasks

gucio321 opened this issue Nov 5, 2024 · 1 comment

Assignees

Collaborator

gucio321 commented Nov 5, 2024 •

edited

Loading

Hi
I plan to do another series of PRs to clean up cmd/codegen.
Here are my notes on what I am planning to do:

Split 618 lines of typedefs generation (Code cleanup #374 )
write a separated logger*: Logger updates #394
remove these 2 booleans from GetArgumentWrapper'
change glg.Fails -> glg.Error for functions that are unable to be generated (sounds more appropiate)
make hard-coded maps from gengo.go another JSON file. codegen: Add presets json support #381

I'll update the list as I get another ideas

*currently we have to do

                        if ctx.flags.showNotGenerated {
                                glg.Infof("Duplicate of %s in reference typedefs. Skipping.", k)
                        }

this could be a method of Context

gucio321 self-assigned this

This comment was marked as off-topic.

Sign in to view

gucio321 mentioned this issue

Codegen refactor and cleanup #391

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment