Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mask passwords in logs #238

Open
bagobones opened this issue Feb 3, 2023 · 0 comments · May be fixed by #1219
Open

Mask passwords in logs #238

bagobones opened this issue Feb 3, 2023 · 0 comments · May be fixed by #1219
Labels
enhancement New feature or request

Comments

@bagobones
Copy link

To aid troubleshooting and privacy could passwords be automatically masked in logs?

The format of most rtsp / rtmp urls are standard and http urls will likely have commonly named parameters.
@AlexxIT AlexxIT added the enhancement New feature or request label Feb 3, 2023
@NickM-27 NickM-27 mentioned this issue Jan 3, 2024
Closed
martinohmann added a commit to martinohmann/go2rtc that referenced this issue Jun 21, 2024
@martinohmann
fix: redact passwords in logs
a3f82bd 
Fixes AlexxIT#238

Replaces URLs of the format `rtsp://user:password@localhost:8554` with
`rtsp://user:xxxxx@localhost:8554` in logs. This is best-effort for now
and does not handle cases where passwords appear in query strings. It
should be fairly easy to extend the `RedactPassword` function in the
future in case there are other common password pattern that are worth
handling.
@martinohmann martinohmann linked a pull request Jun 21, 2024 that will close this issue
Open
martinohmann added a commit to martinohmann/go2rtc that referenced this issue Jun 21, 2024
@martinohmann
fix: redact passwords in logs
98e4f2f 
Fixes AlexxIT#238

Replaces URLs of the format `rtsp://user:password@localhost:8554` with
`rtsp://user:xxxxx@localhost:8554` in logs. This is best-effort for now
and does not handle cases where passwords appear in query strings. It
should be fairly easy to extend the `RedactPassword` function in the
future in case there are other common password pattern that are worth
handling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: redact passwords in logs martinohmann/go2rtc
2 participants
@AlexxIT @bagobones