Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to wrap each button in span? #14

Open
spekulatius opened this issue Feb 9, 2020 · 1 comment
Open

Need to wrap each button in span? #14

spekulatius opened this issue Feb 9, 2020 · 1 comment

Comments

@spekulatius
Copy link
Contributor

Hello @Alexandrshy

I tried to implement your lib in a project of mine. I've noticed, I had to wrap each button in a span to work correctly. Without, only the first button was displayed. Any idea what is causing this?

My code:

    <facebook-button
        isBlank="false"
        btnText="Post"
    />
    <twitter-button
        isBlank="false"
        btnText="Tweet"
    />
    <reddit-button
        isBlank="false"
        btnText="Post"
    />

Expected Behavior

image

Actual Behavior

image

Work around:

        <span>
          <facebook-button
            isBlank="false"
            btnText="Post"
        />
        </span>
        <span>
          <twitter-button
            isBlank="false"
            btnText="Tweet"
        />
        </span>
        <span>
          <reddit-button
            isBlank="false"
            btnText="Post"
        />
        </span>

Maybe I'm doing something wrong? While it looks pretty straight forward I'm not sure...

Cheers,
Peter

@ErnestAV
Copy link

ErnestAV commented Oct 5, 2022

I would suggest putting them all under a

    <div class="flex flex-row justify-center">
         <TwitterButton
            description=""
        />
        <FacebookButton
            description="This recipe will live rent-free in your mind!"
        />
        <PinterestButton
            description="This recipe will live rent-free in your mind!"
        />
    </div>

Result
Screen Shot 2022-10-05 at 8 31 14 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants