Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Album artist is set based on song title's position in alphabet, which is weird #353

Open
1 task done
nift4 opened this issue Dec 19, 2024 · 0 comments
Open
1 task done
Assignees
Labels
bug Something isn't working

Comments

@nift4
Copy link
Collaborator

nift4 commented Dec 19, 2024

Describe the bug
Album artist is set when finding the first song from that album based on artist field, which is a bit too simple.
Compilation albums commonly have no album artists, and if less than 80% or something of songs have the same artist and there is no album artist set, should we just scrap it and say "Various artists"?
https://github.com/AkaneTan/libPhonograph/blob/f7470b5dbc66858dc9b502a00f382093a70cd584/libPhonograph/src/main/java/uk/akane/libphonograph/reader/Reader.kt#L323

Additional context
Received per E-Mail

  • I will open one issue per bug, follow the issue format and will add [BUG] to the start of my issue title, and I acknowledge that if I don't follow the format, my issue might get closed without further explanation.
@nift4 nift4 added the bug Something isn't working label Dec 19, 2024
@nift4 nift4 added this to the TOT cycle cut-off december 2024 milestone Dec 19, 2024
@nift4 nift4 self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant