Integation tests for PgSQL connector #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanyu
previously requested changes
Jan 8, 2021
src/integration-test/java/io/aiven/connect/jdbc/pg/AbstractPgSqlAwareIT.java
Outdated
Show resolved
Hide resolved
src/integration-test/java/io/aiven/connect/jdbc/pg/AbstractPgSqlAwareIT.java
Outdated
Show resolved
Hide resolved
src/integration-test/java/io/aiven/connect/jdbc/AbstractIT.java
Outdated
Show resolved
Hide resolved
src/integration-test/java/io/aiven/connect/jdbc/pg/PgSqlSinkConnectorIT.java
Outdated
Show resolved
Hide resolved
src/integration-test/java/io/aiven/connect/jdbc/pg/PgSqlSinkConnectorIT.java
Outdated
Show resolved
Hide resolved
src/integration-test/java/io/aiven/connect/jdbc/pg/PgSqlSourceConnectorIT.java
Outdated
Show resolved
Hide resolved
willyborankin
force-pushed
the
integration_tests
branch
from
4366738 to
5ea08e4
Compare
willyborankin
force-pushed
the
integration_tests
branch
from
5ea08e4 to
0bf8ac8
Compare
Add Github Actions workflow for making releases
Release version 6.3.1
The default JDK version in workflow build is 8 while we use 11. This change set up JDK version to 11 for the build
Setup jdk version in workflow
ivanyu
reviewed
Feb 11, 2021
Comment on lines
+203
to
+206
| if (project.hasProperty("tablePollIntervalMs")) { | ||
| //pass table.poll.interval.ms | ||
| systemProperty("integration-test.table.poll.interval.ms", project.hasProperty("tablePollIntervalMs")) | ||
| } |
There was a problem hiding this comment.
I'm not sure it's a good idea to put the burden of choosing this value (or even knowing the value must be chosen) on whoever is going to run the tests. For example, I frankly have no idea what I should insert here without some research. We just need one good enough value set as a constant in tests somewhere.
ivanyu
reviewed
Feb 11, 2021
|
|
||
| public class AbstractPgSqlAwareIT extends AbstractIT { | ||
|
|
||
| static final Logger LOGGER = LoggerFactory.getLogger(PostgreSQLContainer.class); |
There was a problem hiding this comment.
Suggested change
| static final Logger LOGGER = LoggerFactory.getLogger(PostgreSQLContainer.class); | |
| static final Logger LOGGER = LoggerFactory.getLogger(AbstractPgSqlAwareIT.class); |
ivanyu
reviewed
Feb 11, 2021
| return AdminClient.create(adminClientConfig); | ||
| } | ||
|
|
||
| private static Path setupPluginDir() throws Exception { |
There was a problem hiding this comment.
Technically could be run in some @BeforeAll instead of @BeforeEach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.