-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errors.tolerance support? #34
Comments
Hi, |
My company is considering implementing support for errors.tolerance and ErrantRecordReporter. Is there a recommendation with respect to the http-connector batch mode? Using batch mode will be a lot of extra work to figure out which records worked and which had an issue and then likely need to report multiple Errant records. It might be simpler to remove batch support to support reporting Errant records. Any other suggestions on direction to implement would be helpful so changes can be posted back here as a PR. Thanks! |
@ivanyu Hi, I am wondering what your opinion is on the above? Is it okay to remove the batch mode logic when adding errors.tolerance and ErrantRecordReporter functionality? |
This would be useful functionality. We use this connector to replicate traffic from a production environment to a staging environment, forwarding the raw payload. Currently, any bad request to the main API causes the connector to stop. |
Sorry for the very long delay! Do I understand correctly that you think of integration like in this test, i.e. the connector will itself send messages to the DLQ? |
No worries @ivanyu. Yes, the Sink will report the message with the ErrantRecordReporter if configured with errors.tolerance and DLQ handling, and the Connector will send the message to the DLQ. It would involve increasing the minimum supported Kafka version to 2.6.3, as ErrantRecordReporter showed up in Kafka 2.6. |
Sounds good to me, @CodeLikeAGecko, please submit the PR! I think a good strategy would be to fail somewhere in the configuration checking with the error message if both DLQ and batching are configured. |
@lavalex errors.tolerance = all Kafka Connect framework does the work. |
Hi! |
Sorry for the ever-so-slight necro, but it seems that at least the |
Hello,
Does the connector support ignoring errors or putting errors and responses to another topic?
The text was updated successfully, but these errors were encountered: