Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AGE-452] [bug] create_new_evaluator_config not setting default correct_answer value #1916

Open
mmabrouk opened this issue Jul 19, 2024 · 2 comments
Labels
Backend bug Something isn't working SDK

Comments

@mmabrouk
Copy link
Member

Creating new evaluator configurations programatically fails unexpectedly. The reason is that in the default call, the correct_answer value is set to None instead to the default correct_answer.

response = self.client.evaluators.create_new_evaluator_config(
            app_id=app_id,
            name=name,
            evaluator_key="auto_webhook_test",
            settings_values={"webhook_url": webhook_url},
        )

We should either set the value per default to correct_answer (in the SDK, or in the backend if set to None), or raise an Exception if the call is done without providing a correct answer value.

Context for the bug

From SyncLinear.com | AGE-452

@mmabrouk mmabrouk added Backend bug Something isn't working Medium priority Created by Linear-GitHub Sync SDK and removed Medium priority Created by Linear-GitHub Sync labels Jul 19, 2024
@bilalqv
Copy link

bilalqv commented Aug 4, 2024

Hi @mmabrouk , I wanted to work on this issue. Can you assign it to me.

@mmabrouk
Copy link
Member Author

mmabrouk commented Aug 5, 2024

That's great. Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend bug Something isn't working SDK
Projects
None yet
Development

No branches or pull requests

2 participants