Simplify Image tag caching #1982
tarunwadhwa13
started this conversation in
Ideas
Replies: 1 comment
-
Hi @tarunwadhwa13, Thank you for your interest and energy ! We looked into your suggestion and we do think that it would be great to make the change. However, as part of our roadmap, we are planning to make several changes, in the next few weeks, that might heavily impact many sections of the current codebase, including the ones that would be affected by your proposal. I would suggest that you keep an eye on our changes and that we discuss this again in a few weeks in case your proposal is still applicable. What do you think ? Thank you again and don't hesitate to suggest more improvements ! Cheers, |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
First of all, thanks for this great product. I really like the vision and would like to contribute to make it even more awesome !!!!
I wanted to propose the idea of simplifying image tag to variant mapping.
Current design requires pulling all tags, matching if the tag name is present in s3 config and then saving in DB
Proposal -
Benefits -
I can raise a PR to make this change if everyone else. Or in case there was a reason for this flow which I missed or mis-understood
Code ref - https://github.com/Agenta-AI/agenta/blob/main/agenta-backend/agenta_backend/services/templates_manager.py#L39
Beta Was this translation helpful? Give feedback.
All reactions