Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test improvements #146

Open
3 tasks done
joao-m-santos opened this issue Jan 31, 2023 · 3 comments
Open
3 tasks done

Unit test improvements #146

joao-m-santos opened this issue Jan 31, 2023 · 3 comments
Assignees

Comments

@joao-m-santos
Copy link
Contributor

Feature description

  • Add missing unit tests
  • Improve current suite

Problem/motivation

Tests are outdated right now, and also not the best in terms of quality and what they're testing

Describe alternatives you've considered

No response

Additional context

No response

Validations

@joao-m-santos joao-m-santos linked a pull request Jan 31, 2023 that will close this issue
6 tasks
@govind-srinidhi
Copy link
Contributor

govind-srinidhi commented Apr 6, 2023

Is it up for grabs?

And how about re-writing the tests with Testing library, as this is the recommended component test library by Vue community.
Is it worth starting writing tests with testing library now or should we take it up after open source?

@joao-m-santos
Copy link
Contributor Author

joao-m-santos commented Apr 6, 2023

Is it up for grabs?

yes!

And how about re-writing the tests with Testing library, as this is the recommended component test library by Vue community. Is it worth starting writing tests with testing library now or should we take it up after open source?

I think it's a good idea to move to Testing Library. I suggest you try it in a branch, if it works fine with our setup let's go for it

@govind-srinidhi
Copy link
Contributor

Cool :)
Yeah, picking it up then :D

@govind-srinidhi govind-srinidhi self-assigned this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants