Various properties in FrontendProxyController do not use the Abstract* version but the constructor does

[AndreasA]

Describe the bug

If one e.g. decorates the CartOrderRoute by extending the AbstractCartOrderRoute, it will work for the constructor but fails to be stored in the property as the property typehinting only allows CartOrderRoute directly.

The same is true for various other properties / constructor services.

Versions
Shopware version: [e.g. 6.5.4.4]
Plugin version: [e.g. 3.12.1]

see e.g. https://github.com/Adyen/adyen-shopware6/blob/3.12.1/src/Storefront/Controller/FrontendProxyController.php#L54 and https://github.com/Adyen/adyen-shopware6/blob/3.12.1/src/Storefront/Controller/FrontendProxyController.php#L63

[AndreasA]

also: is that controller actually necessary? why not just call the store api directly as I think shopware does also?

[peterojo]

@AndreasA this controller was created only to be able to access store-api routes from our frontend components in shopware 6.5 and this is necessary because of this change

[AndreasA]

Hi @peterojo

Ok. So did not add another solution regarding proxy routing except to implement a corresponding contorller manually. Weird.

Anyway, my main point was that if I use a service decoration for e.g. Shopware\Core\Checkout\Cart\SalesChannel\CartOrderRoute like:

namespace Foo;

public class DecoratedCartOrderRoute extends AbstractCartOrder {
   ....
}

<?xml version="1.0" encoding="UTF-8" ?>
<container xmlns="http://symfony.com/schema/dic/services"
    xmlns:xsd="http://www.w3.org/2001/XMLSchema-instance"
    xsd:schemaLocation="http://symfony.com/schema/dic/services https://symfony.com/schema/dic/services/services-1.0.xsd">
    <services>
        <service id="Foo\DecoratedCartOrderRoute "
            decorates="Shopware\Core\Checkout\Cart\SalesChannel\CartOrderRoute"
        />
    </services>
</container>

Routes like /adyen/proxy-switch-context will fail to work as the controller expects the property to be of the type CartOrderRoute not AbstractCartOrderRoute

[AndreasA]

@peterojo I could create a PR for this, it should be quite straight forward.

[adyen-integrations-support]

Hey @AndreasA @peterojo @candemiralp

Can you please let us know if additional work should be done or if this issue can be closed?

Thank you!

[AndreasA]

3.6.13 seems to use the correct route in https://github.com/Adyen/adyen-shopware6/blob/3.16.3/src/Storefront/Controller/FrontendProxyController.php#L100

However, I probably won't be able to verify this in the near future and also verify if there might be other problematic services.