Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different design: more compact windows and collapsing/closing control on each tab bar #238

Open
micfong-z opened this issue May 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@micfong-z
Copy link

micfong-z commented May 13, 2024

Currently, detached windows have a window header for collapsing header and close button, which takes quite a lot of space above each window. The flexibility of splits are also limited as I could not collapse nodes (technically Leafs) individually.

I'd like to suggest a different design of window/node controls as shown in the screen recording below. (Pull request #237)

Screen.Recording.2024-05-13.at.22.24.45.mov

This design is more similar to ImGui's approach. (No worries, this design works with the add tab button as well, see #237 for a sample implementation)


Here are some advantages I could come up with this design:

  • More flexibility with collapsing docked Leafs, including those in the main surface.
  • More compact windows.
  • Clearer display of what tabs are included in a collapsed window.
  • Closing all tabs on a node is sometimes more useful than closing an entire surface.
  • Potential for further functionality (e.g. detaching a window with all tabs in a Leaf by dragging out the Leaf from the collapsing button, similar to that in ImGui).

Significant drawbacks:

  • More space taken for fully collapsed windows.
  • No more buttons for collapsing or closing an entire detached window. (A workaround is to put those two buttons to the right-click context menu of the corresponding buttons in all tab bars)
  • May sacrifice a little bit of performance (not tested yet).

I'd like to hear some opinions (criticism?) before moving on in #237.

@Adanos020
Copy link
Owner

This looks very good! I'll take a look at your PR, but really well done so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants