Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you consider updating the repo with fixes from the original sourceforge prj? #8

Open
fedesasso opened this issue May 1, 2018 · 3 comments

Comments

@fedesasso
Copy link

Hi there,
I understand (after reading a previous reply of yours) you consider this repo as a personal mirror of the "real thing", but would you consider merging the latest changes made to the original sourceforge project?
There are several improvements and fixes there added after your Mar 23, 2014 (I my understanding is correct, it was forked from r88 2012-11-16, the original branch is now r98 2014-09-09 20:30:21)

You yourself added a few bug fixes. It would be nice having a unique up-to-date repo since the original project appears to be dead.

@ilexp
Copy link
Member

ilexp commented May 1, 2018

I'm 100% with you on this, but I'm very short on time due to my main project and real life, so I cannot promise anything right now. I'll leave this issue open as a way to come up with a plan, but will likely not act on it soon.

@fedesasso
Copy link
Author

Thank you, Adam.
Also, do you accept patches?
I've found a major performance issue that appears when one adds tens of thousands of children under a node - Node.NodeCollection.InsertItem(..) is affected by a "Shiemel the Painter" bug - and other threading issues. At the moment I just worked them around, but wish to attempt a proper fix for the future.

@ilexp
Copy link
Member

ilexp commented May 1, 2018

I have occasionally accepted patches and smaller tweaks in the past, so if it's nothing too big I'd look forward to a PR on that matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants