Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules called ignore are incorrectly formatted #247

Closed
elbrujohalcon opened this issue Apr 29, 2021 · 7 comments
Closed

Modules called ignore are incorrectly formatted #247

elbrujohalcon opened this issue Apr 29, 2021 · 7 comments
Labels
bug Something isn't working
Milestone
1.1.0

Comments

@elbrujohalcon
Copy link
Collaborator

Describe the bug

Parentheses are removed when formatting a module called ignore.

To Reproduce

Try to format this…

-module(ignore).

It's formatted as…

-module ignore.

Expected behavior

-module(ignore).
@elbrujohalcon elbrujohalcon added the bug Something isn't working label Apr 29, 2021
@elbrujohalcon elbrujohalcon added this to the 1.1.0 milestone Apr 29, 2021
@paulo-ferraz-oliveira
Copy link
Contributor

It's an easter egg.

@elbrujohalcon
Copy link
Collaborator Author

🥚

@paulo-ferraz-oliveira
Copy link
Contributor

On a more serious note I find that not being able to express ignore => [atom()], in the options, is hindering. I had to do "src/module.erl" (didn't check without the src).

@elbrujohalcon
Copy link
Collaborator Author

You mean in rebar.config's format section, right?

@paulo-ferraz-oliveira
Copy link
Contributor

Yes.

@elbrujohalcon elbrujohalcon mentioned this issue Apr 29, 2021
Open
@elbrujohalcon
Copy link
Collaborator Author

☝️ #248

vkatsuba added a commit to vkatsuba/rebar3_format that referenced this issue May 5, 2021
@vkatsuba
Fix for AdRoll#247
ff779b7 
Related to AdRoll#247
@vkatsuba vkatsuba mentioned this issue May 5, 2021
Merged
vkatsuba added a commit to vkatsuba/rebar3_format that referenced this issue May 5, 2021
@vkatsuba
Fix for AdRoll#247
294d871 
Related to AdRoll#247
vkatsuba added a commit to vkatsuba/rebar3_format that referenced this issue May 5, 2021
@vkatsuba
Fix for AdRoll#247
0594f93 
Related to AdRoll#247
elbrujohalcon pushed a commit that referenced this issue May 6, 2021
@vkatsuba
Fix for #247 (#253)
5a53545 
Related to #247
@elbrujohalcon
Copy link
Collaborator Author

Fixed with #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.1.0
Development

No branches or pull requests
2 participants
@elbrujohalcon @paulo-ferraz-oliveira