Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does hologram me need a separate protocol message? #38

Open
copumpkin opened this issue Apr 1, 2015 · 2 comments
Open

Does hologram me need a separate protocol message? #38

copumpkin opened this issue Apr 1, 2015 · 2 comments

Comments

@copumpkin
Copy link
Contributor

I was just dealing with the client/server portion of the code and noticed that the handling for hologram me is almost identical to hologram use, except that it assumes the default role. Could the client/server portion be simplified by unifying the messages and logic processing them?

@frangarciam
Copy link
Contributor

Absolutely!

One of the things on my radar was to simplify that part of the code, and that's one of the main candidates :)

Looks like the AssumeRole message has both user and role as optional, so it should be fairly easy to change the code to send an AssumeRole message with empty role as a result of hologram me and the server using the default role for it.

@epall
Copy link
Contributor

epall commented Apr 22, 2015

hologram me vs. hologram use was a distinction back when we were using both AssumeRole and GetSessionToken on the STS API. Since it's just AssumeRole now, yeah, we should only have one protocol message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants