Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist settings to server #394

Closed
iloveitaly opened this issue Jun 12, 2023 · 8 comments
Closed

Persist settings to server #394

iloveitaly opened this issue Jun 12, 2023 · 8 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@iloveitaly
Copy link
Contributor

Is there a reason we don't persist categorization preferences on the server side? I can't imagine why this wouldn't be preferred. Would be a great QOL improvement.

@ErikBjare ErikBjare added enhancement New feature or request help wanted Extra attention is needed labels Jun 17, 2023
@ErikBjare
Copy link
Member

ErikBjare commented Jun 17, 2023

Tried to find the tracking issue for this, but couldn't find it.

The plan is:

  • add a KV store to the databases
  • implement appropriate API endpoint
  • make aw-webui always check server settings first, and if not present, initialize with store browser localstore settings (upgrade) or defaults (init).

I found this:

What's left is adding support to aw-server-python (should be easy, just need to get the db migration right, but I just did something similar in ActivityWatch/aw-server#128), then just do the aw-webui part.

I agree it would be a great QOL improvement, I've just personally gotten a bit lazy as it's good enough for me.

I just added a link to this issue from the web UI: ActivityWatch/aw-webui@1f194ff

Contributions welcome!

@ErikBjare ErikBjare changed the title persist categorization preferences Persist settings to server Jun 17, 2023
@PetbkA
Copy link

PetbkA commented Aug 18, 2023

v0.12.3b6 - BTW, current warning about settings storage isn't quite correct:

These settings are only saved in your browser and will not remain if you switch browser

Settings aren't even depend on browser but rather on cookies, 'cause if you clear them for AW site - you'll lost your settings even without switching browser

@ErikBjare
Copy link
Member

@PetbkA They are technically stored in localStorage, not cookies.

But yes, if the user clears the site data then it is lost.

@ErikBjare
Copy link
Member

I finished this today, see ActivityWatch/aw-webui#493

Might need some battle-testing in beta releases (releasing v0.12.3b11 later today), but seems pretty ready!

@ErikBjare
Copy link
Member

Tracking issue was here: ActivityWatch/activitywatch#348

@iloveitaly
Copy link
Contributor Author

Woohoo! So exciting :)

@RokeJulianLockhart
Copy link

RokeJulianLockhart commented Jan 7, 2024

#394 (comment)

@ErikBjare, this issue is still cited in the AW AOSP GUI:

Screenshot_20240107-140452.png

@ErikBjare
Copy link
Member

@RokeJulianLockhart The Android app is running an older version of the web UI and server.

Once it gets updated (might be a while), the notice will disappear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants