Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve import result message interface #394

Open
rakleed opened this issue Mar 25, 2020 · 4 comments
Open

Improve import result message interface #394

rakleed opened this issue Mar 25, 2020 · 4 comments

Comments

@rakleed
Copy link
Contributor

rakleed commented Mar 25, 2020

Feature requests on the forum

Is your feature request related to a problem? Please describe.
Upon successful import, a null message is displayed, which is very difficult to associate with a successful import. And if import fails, the message {"message": "Internal Server Error"} is displayed all the time, which also does not say what the problem is.

Describe the solution you'd like
If import is successful, the message Import completed successfully! is displayed. And if import fails, a message is displayed that the import could not be completed, and the specific reason why (and also its solution is possible).

Describe alternatives you've considered

Additional context
The server should give the correct error messages, which can be displayed in the web interface to the user.

@ErikBjare
Copy link
Member

Good catch, been thinking about this before but never opened an issue. We'll implement this in aw-server-rust, which is destined to become the default server soon™.

@johan-bjareholt
Copy link
Member

johan-bjareholt commented Mar 26, 2020

@ErikBjare The datastore actually already returns the exact error in aw-server-rust, it's just a matter of sending it in the HTTP body response.

@nicolae-stroncea
Copy link
Member

This would be slightly more complex (for a minor issue), but it would be great to stay on the same page, and instead just get the HTTP response in a box/alert that you can then close

@johan-bjareholt
Copy link
Member

johan-bjareholt commented Jun 27, 2020

This would be slightly more complex (for a minor issue), but it would be great to stay on the same page, and instead just get the HTTP response in a box/alert that you can then close

This is now in progress here:

ActivityWatch/aw-webui#210

Next step is to return the actual error from aw-server and make the alert show that message, then we can consider this issue to be fixed. Right now it only says "Importing failed, see aw-server logs for more info"

@stale stale bot added stale and removed stale labels Dec 24, 2020
@stale stale bot added stale and removed stale labels Jun 23, 2021
@stale stale bot added the stale label Jun 28, 2022
@stale stale bot removed the stale label Jul 5, 2022
@stale stale bot added stale and removed stale labels Aug 12, 2023
@ErikBjare ErikBjare reopened this Oct 19, 2023
@ActivityWatch ActivityWatch deleted a comment from stale bot Oct 19, 2023
@ActivityWatch ActivityWatch deleted a comment from stale bot Oct 19, 2023
@ActivityWatch ActivityWatch deleted a comment from stale bot Oct 19, 2023
@ActivityWatch ActivityWatch deleted a comment from stale bot Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants