-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements to Acode Plugin installer #1026
Comments
Clearly explain it in detail |
Like an array of plugins in {
"dependencies": [
"bajrangcoder.acodex", "sebastianjnuwu.acode.eruda"
]
} |
I am willing to assist in implementing this |
Ok |
Contributions are welcomed |
I had already talked about this, the system is similar to that of vscode, the .acode folder has the settings and dependencies and acode recognizes itself when the project folder is open if not with the default I tried to do it, but I had some problems regarding recognizing the file and downloading the plugins. The paid plugins gave an error when downloading since they have a different API logic. |
Currently when updating Plugins the installer does not delete the previous installation of the plugin rather it installs the update over the current installation. There is a problem of redundant files.
and this is the update
after updating this will be the current installation
|
I suggest using a combination of id and version as the plugin folder name `${plugin.id}-${plugin.version}` instead of just id |
Nice, I haven't noticed this.
I think it will be good to remove the previous folder and then add the new update one , as the the id and version combination will make different instances of same plugin. If you have any better idea then please share |
Removing the previous folder and then installing the update will introduce some latency when updating a plugin, while this might go unnoticed for plugins with few files for plugins with close to a thousand files it will be noticed. We can keep a mapping of plugin IDs to their folders. |
Actually that latency will be visible in other approaches too. |
What about obsolete files? How do we detect them? |
We can detect it: |
Yes this is better, because some plugins assume the plugin folder to be it's id |
I will begin working to implement this |
Currently Acode ignores the following fields in the plugin manifest file and uses static values instead
|
Yes, I planned to fix it but I forgot |
I can help in implementing the fixes |
1 similar comment
I can help in implementing the fixes |
Open a pr |
Is it possible to add support for plugin dependencies?
The text was updated successfully, but these errors were encountered: