Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce code format check and linter check #23

Closed
Tracked by #3
miroslavpojer opened this issue Jul 18, 2024 · 1 comment · Fixed by #29
Closed
Tracked by #3

Introduce code format check and linter check #23

miroslavpojer opened this issue Jul 18, 2024 · 1 comment · Fixed by #29
Assignees
@MobiTikula
Labels
refactoring Improving code quality, paying off tech debt, aligning APIs

Comments

@miroslavpojer
Copy link
Collaborator

miroslavpojer commented Jul 18, 2024 •
edited
Loading

  • Introduce a check of the code formatting used.

    • Try use pylint
    • Propose a better solution if found. (keep an eye on the licence)

  • Checks have to run both on local and CI.
@miroslavpojer miroslavpojer mentioned this issue Jul 18, 2024
Closed
@miroslavpojer miroslavpojer added the enhancement New feature or request label Jul 18, 2024
@MobiTikula MobiTikula self-assigned this Aug 9, 2024
@MobiTikula MobiTikula added refactoring Improving code quality, paying off tech debt, aligning APIs and removed enhancement New feature or request labels Aug 12, 2024
@MobiTikula MobiTikula linked a pull request Aug 12, 2024 that will close this issue
Refactoring/23 introduce code format check and linter check #29
Merged
@miroslavpojer miroslavpojer mentioned this issue Aug 20, 2024
Merged
@github-actions GitHub Actions
Copy link

Release notes

  • Pylint suggestions implemented in the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MobiTikula MobiTikula

Labels
refactoring Improving code quality, paying off tech debt, aligning APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactoring/23 introduce code format check and linter check AbsaOSS/living-doc-generator
2 participants
@MobiTikula @miroslavpojer