Add income field logic + few minor changes #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no current field to represent the income of a saved contact. This information is important to know when serving customers. Creating this field allows for contacts to have an associated income level. As of v1.2, the `add` and `edit` commands can be used to add a new contact with the income field being mandatory, and edit an existing contact's income level accordingly.
Tests broke because of the new definition of person and its constructor. In addition, changes to equality logic broke some existing tests. Adding income as a parameter fixes the tests. Adjusting the equality logic tests, such that a person is equal to another person if their - name - email - address are equal. We will need to discuss criteria for two persons being equal to each other and adjusting our test logic accordingly.
itsme-zeix
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45.