Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Manual Testing for edit command in DG #332

Merged
merged 7 commits into from
Nov 11, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ The `CombinedPredicate` is applied to each client in AgentAssist, evaluating whe
**Status:** Scheduled for future release due to the complexity of potential solutions and risk of introducing new bugs.

### 3. Support for Symbols such as `@` and Parentheses in Names
**Current Issue:** ames containing symbols like `@` and parentheses (e.g., `John @ Doe` or `Jane (Admin) Smith`) are currently incompatible with the `add`, `edit`, and `filter` commands because support for these characters has not been implemented yet. Although such cases are rare, the current name validation regex excludes these symbols.
**Current Issue:** Names containing symbols like `@` and parentheses (e.g., `John @ Doe` or `Jane (Admin) Smith`) are currently incompatible with the `add`, `edit`, and `filter` commands because support for these characters has not been implemented yet. Although such cases are rare, the current name validation regex excludes these symbols.

**Technical Impact:**
- There are no anticipated issues with allowing these symbols in names. The main reason for the lack of support is the low frequency of such cases, making it a lower priority for development.
Expand Down Expand Up @@ -697,6 +697,29 @@ testers are expected to do more *exploratory* testing.
1. Prerequisites: Use the `filter` command with a suitable flag. Multiple clients in the list.
2. Functions similar to above example except that the indexes to be used are based on the new list shown.

### Editing a client

1. Editing a client while all clients are being shown

1. Prerequisites: List all clients using the `list` command. At least one client in the list.
2. Test case: `edit 1 n/ <NAME>`<br>
Expected: The name of the client in index 1 will be changed to <NAME>.
3. Test case: `edit 1 n/ <NAME> p/<PHONE>`<br>
colinhia marked this conversation as resolved.
Show resolved Hide resolved
Expected: The name and the phone of the client in index 1 will be changed to <NAME> and <PHONE> respectively.
4. Other correct edit commands to try: `edit 1 n/ <NAME> p/<PHONE> e/ <EMAIL>`, `...` (for any number of valid flags and valid arguments)<br>
colinhia marked this conversation as resolved.
Show resolved Hide resolved
Expected: Similar to previous.
5. Test case: `edit 0 n/ <NAME>`<br>
Expected: An error message is shown to the user. No edits are made to client details. Error details shown in the status message.
6. Other incorrect edit commands to try:<br>
`edit 1 f/<INVALID_VALUE>` (where f is a valid flag),<br>
`edit x n/<NAME>` (where x is larger than list size),<br>
`edit 1 y/<VALUE>` (where y is an invalid flag) <br>
Expected: Similar to previous.

2. Editing a client after having filtered based on a criteria
1. Prerequisites: Use the `filter` command with a suitable flag. Multiple clients in the list.
2. Functions similar to above example except that the indexes to be used are based on the new list shown.

### Saving data

1. Dealing with missing/corrupted data files
Expand Down
2 changes: 1 addition & 1 deletion docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@ While it has a GUI, most of the user interactions happen using a CLI (Command Li

* This project is based on the AddressBook-Level3 project created by the [SE-EDU initiative](https://se-education.org).

* Libraries used: [JavaFX](https://openjfx.io/), [Jackson](https://github.com/FasterXML/jackson), [JUnit5](https://github.com/junit-team/junit5)
* Libraries used: [JavaFX](https://openjfx.io/), [Jackson](https://github.com/FasterXML/jackson), [JUnit5](https://github.com/junit-team/junit5), [Ikonli](https://github.com/kordamp/ikonli)