From 2b9a6406db452256f86c0668e6969f2333e26ef7 Mon Sep 17 00:00:00 2001 From: Bastian Schmidt Date: Tue, 9 Apr 2024 08:36:01 +0200 Subject: [PATCH 1/2] Add yamllint GitHub action Integrate the following yamllint GitHub action as it seems well maintained. It lints all yaml files in the repo: https://github.com/marketplace/actions/yaml-lint --- .github/workflows/yamllint.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) create mode 100644 .github/workflows/yamllint.yml diff --git a/.github/workflows/yamllint.yml b/.github/workflows/yamllint.yml new file mode 100644 index 0000000..b565bee --- /dev/null +++ b/.github/workflows/yamllint.yml @@ -0,0 +1,11 @@ +--- +name: Yaml Lint +on: [push] # yamllint disable-line rule:truthy +jobs: + lintAllTheThings: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + - name: yaml-lint + uses: ibiqlik/action-yamllint@v3 + From 29417df590a7d7b7c0c3718a35084c87bf77d845 Mon Sep 17 00:00:00 2001 From: Bastian Schmidt Date: Tue, 9 Apr 2024 08:40:49 +0200 Subject: [PATCH 2/2] Fix yamllint errors and warnings * In rubocop.yml * In GitHub action configs --- .github/workflows/js_tests.yml | 2 ++ .github/workflows/ruby_tests.yml | 3 ++- .github/workflows/yamllint.yml | 4 ++-- .rubocop.yml | 1 + 4 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/js_tests.yml b/.github/workflows/js_tests.yml index df123da..23473a5 100644 --- a/.github/workflows/js_tests.yml +++ b/.github/workflows/js_tests.yml @@ -1,4 +1,6 @@ +--- name: JavaScript Testing +# yamllint disable-line rule:truthy on: push: branches: diff --git a/.github/workflows/ruby_tests.yml b/.github/workflows/ruby_tests.yml index 14768f4..11e0811 100644 --- a/.github/workflows/ruby_tests.yml +++ b/.github/workflows/ruby_tests.yml @@ -1,6 +1,7 @@ --- name: Ruby Tests -"on": +# yamllint disable-line rule:truthy +on: push: branches: - main diff --git a/.github/workflows/yamllint.yml b/.github/workflows/yamllint.yml index b565bee..12c51e5 100644 --- a/.github/workflows/yamllint.yml +++ b/.github/workflows/yamllint.yml @@ -1,6 +1,7 @@ --- name: Yaml Lint -on: [push] # yamllint disable-line rule:truthy +# yamllint disable-line rule:truthy +on: [push] jobs: lintAllTheThings: runs-on: ubuntu-latest @@ -8,4 +9,3 @@ jobs: - uses: actions/checkout@v3 - name: yaml-lint uses: ibiqlik/action-yamllint@v3 - diff --git a/.rubocop.yml b/.rubocop.yml index a0dc306..57372cb 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,3 +1,4 @@ +--- inherit_gem: theforeman-rubocop: - strictest.yml