Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge the INSAR_ISCE_MULTI_BURST job spec with INSAR_ISCE_BURST #2442

Open
8 tasks
jtherrmann opened this issue Oct 1, 2024 · 0 comments
Open
8 tasks

Merge the INSAR_ISCE_MULTI_BURST job spec with INSAR_ISCE_BURST #2442

jtherrmann opened this issue Oct 1, 2024 · 0 comments
Labels
Jira Task Create a Jira Task for this issue

Comments

@jtherrmann
Copy link
Contributor

jtherrmann commented Oct 1, 2024

Jira: https://asfdaac.atlassian.net/browse/TOOL-3145

Note: The above link is accessible only to members of ASF.


Currently we have an INSAR_ISCE_MULTI_BURST job spec (which takes reference and secondary parameters) and a separate INSAR_ISCE_BURST job spec (which takes a granules parameter) because it was the easiest way to merge the multi-burst work to main without breaking backwards compatibility for INSAR_ISCE_BURST.

For this issue, we'll want to merge the two job specs as follows:

  • Add the granules parameter to INSAR_ISCE_MULTI_BURST.yml and enforce that either granules or reference and secondary must be used.
  • Rename INSAR_ISCE_MULTI_BURST.yml to INSAR_ISCE_BURST.yml (replacing the existing INSAR_ISCE_BURST.yml)
  • Rename the job type to INSAR_ISCE_BURST (first line of the job spec)
  • Limit reference and secondary each to length 1 (this can be changed back to 30 in the hyp3-multi-burst-sandbox deployment for testing purposes)
  • Remove INSAR_ISCE_MULTI_BURST.yml from hyp3-multi-burst-sandbox deployment
  • Currently the validate_jobs function calls convert_single_burst_jobs to convert the parameters for all INSAR_ISCE_BURST jobs from granules to reference and secondary in validation.py. This will need to be updated to only perform the conversion if the job has a granules parameter. Or we could just handle the granules parameter in the actual validator functions that use the burst granule names (currently that should just be the check_same_burst_ids validator), which is probably the better option.
  • Rename INSAR_ISCE_MULTI_BURST to INSAR_ISCE_BURST everywhere it's used in the code (see git grep INSAR_ISCE_MULTI_BURST); should just be set_batch_overrides.py, test_set_batch_overrides.py, and test_validation.py
  • Add a note to the Changelog that granules is now deprecated for INSAR_ISCE_BURST
@jtherrmann jtherrmann added the Jira Task Create a Jira Task for this issue label Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Jira Task Create a Jira Task for this issue
Projects
None yet
Development

No branches or pull requests

1 participant