Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Adding ability to pass list of files and/or xarray datasets into ARM Data Validator #851

Open
cgodine opened this issue Aug 28, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@cgodine
Copy link
Contributor

cgodine commented Aug 28, 2024

  • ACT version: 2.1.3
  • Python version: 3.11
  • Operating System: MacOS Ventura 13.6.9

Description

Currently, ARM Data Validator (ADV) takes an argument of either a filename string or xarray Dataset and returns a list of error messages. If a user needs to parse multiple files, it might be easier to pass a list of filenames and/or Datasets and have them returned in a dict where the keys are either the filename or Dataset and the value is the list of error messages.

@cgodine cgodine added the enhancement New feature or request label Aug 28, 2024
@cgodine cgodine self-assigned this Aug 28, 2024
@zssherman
Copy link
Collaborator

I think that's a good idea!

@AdamTheisen
Copy link
Collaborator

Hi All, just as a background the initial use case for this was so that a user could check the format of their files. Normally, I would assume that they would use the same script to write out their data to files so running through a list would be redundant for that use case. This function was really not meant to run through ARM's data, which will likely fail a lot of these more recent requirements.

This might take a fair amount of work to update. I would say for this function it's a low priority for the development team to work on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants