Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipping n-train years that are adjacent to a test year #47

Open
BSchilperoort opened this issue Jul 26, 2022 · 0 comments
Open

Skipping n-train years that are adjacent to a test year #47

BSchilperoort opened this issue Jul 26, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@BSchilperoort
Copy link
Contributor

At some point, it would also be nice to have the functionality to skip n-train years that are adjacent to a test year. Highly autocorrelated timeseries may lead to information leakage from one year to the next. To ensure this effect is reduced/negated, you can remove the years adjacent to test years from the training datesets.

See gap_prior and gap_after arguments in legacy code:
https://github.com/AI4S2S/proto/blob/77734930a40b8aaefcf1e390efe0e3ac93b40858/RGCPD/class_RGCPD.py#L312-L314 (edited)

Originally posted by @semvijverberg in AI4S2S/s2spy#52 (comment)

@BSchilperoort BSchilperoort added the enhancement New feature or request label Jul 26, 2022
@BSchilperoort BSchilperoort transferred this issue from AI4S2S/s2spy Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant