92/Refactor pressure level modifications #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truth-quark
commented
Sep 17, 2024
marc-white
reviewed
Sep 17, 2024
blimlim
previously approved these changes
Sep 18, 2024
truth-quark
commented
Sep 20, 2024
truth-quark
commented
Sep 20, 2024
2 tasks
|
This one needs a final review before merging. @blimlim @marc-white would either of you mind going over the latest changes & conversation threads? |
marc-white
approved these changes
Sep 24, 2024
Argh, GitHub seems to need someone else to resolve the conversations before it'll let me merge... |
CodeGat
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #92.
This PR covers a few tasks:
um2netcdfmodule slightlyKnown gaps:
This work exposes a (possibly one off) case where
irisfuncs return a new cube. Moving the pressure level fixes intoprocess()requires modifying the list of cubes being processed to patch the new cube in. This is noted in the code. The tests are also moderately loose, related to the complexity with testingiriscomponents.It's likely addressing this will have to be deferred until the code is restructured & tested, to allow workflow refactoring.
Otherwise, any comments welcome!