Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify pylint behaviour for umpost #79

Open
truth-quark opened this issue Aug 20, 2024 · 1 comment
Open

Verify pylint behaviour for umpost #79

truth-quark opened this issue Aug 20, 2024 · 1 comment

Comments

@truth-quark
Copy link
Collaborator

During the #74 review, it was unclear if the linter workflow step was skipped the umpost.um2netcdf module due to the --ignored-modules option in .github/workflows/CI.yml:

      - name: Lint
        shell: bash -l {0}
        run: pylint --extension-pkg-whitelist=netCDF4 --ignored-modules=um2netcdf4,umpost -E umpost

There is potential that modules in the umpost package are skipped, in addition to um2netcdf4. Given the mid-August release, this was not confirmed due to lack of time.

The main task is ensuring that umpost modules are linted.
Note: this should happen after #78 to remove old um2netcdf4 imports.

@truth-quark
Copy link
Collaborator Author

The original discussion is here: https://github.com/ACCESS-NRI/um2nc-standalone/pull/74/files#r1721221909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant