Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract history to function #42

Closed
1 task done
truth-quark opened this issue Jul 12, 2024 · 3 comments
Closed
1 task done

Extract history to function #42

truth-quark opened this issue Jul 12, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@truth-quark
Copy link
Collaborator

truth-quark commented Jul 12, 2024

Tasks:

  • Extract file history attribute to function
  • [ ] Move set history to end of process() to group sman I/O operations (for future fixes)
  • [ ] Move set CF conventions to end of process()

Unit tests can likely be skipped as the code is very small.

@truth-quark
Copy link
Collaborator Author

Small problem: moving the functions to update sman attributes changes the order in the NC file, which affects rough testing with diff (if a single byte changes, diff fails). Is there a way to bypass the iris output object sman & set the attributes? Are cube.attributes shared and thus global between all cubes? A hacky option is to set history on a cube & let iris save that to the NC file.

@truth-quark truth-quark added the enhancement New feature or request label Jul 12, 2024
@truth-quark
Copy link
Collaborator Author

Moved sman & comments changes to issue #27. History extraction resolved by #43.

@truth-quark
Copy link
Collaborator Author

Also addresses a task in #14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant