Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Optional Additional Artifact Contents #67

Merged
merged 4 commits into from
Sep 17, 2024
Merged

Add Optional Additional Artifact Contents #67

merged 4 commits into from
Sep 17, 2024

Conversation

CodeGat
Copy link
Collaborator

@CodeGat CodeGat commented Sep 13, 2024 •
edited
Loading

Background

This PR allows the option of adding additional paths from the repro-ci experiment run to the artifact. Used in ACCESS-NRI/access-om3-configs#122

Testing

The PR

In this PR:

  • config-pr-1-ci.yml: Added new additional-artifact-content-paths input, artifact and experiment outputs
  • test-repro.yml: Added optional input for additional artifact contents, rsync additional artifact contents

Closes #66

@CodeGat CodeGat self-assigned this Sep 13, 2024
@CodeGat CodeGat marked this pull request as draft September 13, 2024 01:00
@CodeGat CodeGat marked this pull request as ready for review September 17, 2024 04:05
aidanheerdegen
aidanheerdegen previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/test-repro.yml Show resolved Hide resolved
@CodeGat
Copy link
Collaborator Author

CodeGat commented Sep 17, 2024 •
edited
Loading

Might have to rethink a bit of this...rsyncs that give /some/archive/output000/MOM5_parameter_doc.* do not preserve the folder output000, it would instead dump the MOM5_parameter_doc.* in the root of the artifact, which might be a bit messy...see the last bit of https://github.com/ACCESS-NRI/model-config-tests/pull/67/files#diff-5be99750b9d23ced058ba14262f4d19aa19757167d7cbffe687d7def06ad2aedR160-R162

@CodeGat
Copy link
Collaborator Author

CodeGat commented Sep 17, 2024

Maybe if I do a rsync --relative from $EXPERIMENT_LOCATION, it will preserve the archive/output000/MOM5_parameter_doc.* structure.

@aidanheerdegen
Copy link
Member

Maybe if I do a rsync --relative from $EXPERIMENT_LOCATION, it will preserve the archive/output000/MOM5_parameter_doc.* structure.

Even better

https://askubuntu.com/a/552122

Just insert a dot /./ into the path where you want to break the path

@CodeGat
Copy link
Collaborator Author

CodeGat commented Sep 17, 2024

Done it! 😆

aidanheerdegen
aidanheerdegen approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rsync FTW

@CodeGat CodeGat merged commit d8b10da into main Sep 17, 2024
@CodeGat CodeGat deleted the 66-specifiable-artifact-contents branch September 17, 2024 07:10
@CodeGat CodeGat mentioned this pull request Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanheerdegen aidanheerdegen aidanheerdegen approved these changes

Assignees

@CodeGat CodeGat

Labels
priority:medium type:enhancement type:infra Dealing with CI/CD Pipelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Caller-Specifiable Files for Inclusion in Release Artifacts
2 participants
@CodeGat @aidanheerdegen