Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of generic workflows from ACCESS-NRI/access-om2-configs #24

Merged
merged 15 commits into from
Jun 19, 2024

Conversation

CodeGat
Copy link
Collaborator

@CodeGat CodeGat commented Jun 11, 2024

This PR moves the deleted workflows from https://github.com/ACCESS-NRI/access-om2-configs/pull/117/files into this repo, references the newly-moved workflows, fixes some bugs, and adds a fresh coat of paint.

In this PR:

References #23

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.44%. Comparing base (9d3c1b1) to head (c9d6184).
Report is 1 commits behind head on main.

Current head c9d6184 differs from pull request most recent head 59da225

Please upload reports for the commit 59da225 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   14.44%   14.44%           
=======================================
  Files          11       11           
  Lines         547      547           
=======================================
  Hits           79       79           
  Misses        468      468           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CodeGat CodeGat marked this pull request as ready for review June 14, 2024 01:28
@CodeGat CodeGat requested a review from jo-basevi June 17, 2024 00:59
Copy link
Collaborator

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! I've added a few minor comments.

I might update the how to run tests manually part of the readme, to use virtual environments (so to not install to local directory) and to not use payu modules (as its installed as part of model-config-tests). I can create a separate PR for that section, or add a commit to this one?

.github/actions/parse-ci-config/README.md Outdated Show resolved Hide resolved
.github/workflows/config-pr-1-ci.yml Outdated Show resolved Hide resolved
.github/workflows/config-pr-1-ci.yml Outdated Show resolved Hide resolved
.github/workflows/config-pr-1-ci.yml Outdated Show resolved Hide resolved
.github/workflows/config-schedule-2-start.yml Outdated Show resolved Hide resolved
.github/workflows/config-schedule-2-start.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
.github/workflows/config-pr-1-ci.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@CodeGat
Copy link
Collaborator Author

CodeGat commented Jun 18, 2024

@jo-basevi feel free to commit to this one if it's related :)

@CodeGat CodeGat requested a review from jo-basevi June 18, 2024 23:21
Copy link
Collaborator

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeGat CodeGat merged commit 6885b16 into main Jun 19, 2024
@CodeGat CodeGat deleted the 23-add-infra branch June 19, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants