Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create action for payu config checks #119

Open
aidanheerdegen opened this issue Nov 16, 2023 · 2 comments
Open

Create action for payu config checks #119

aidanheerdegen opened this issue Nov 16, 2023 · 2 comments
Labels
priority:medium A medium priority issue - has some impact on functionality type:feature New feature or request

Comments

@aidanheerdegen
Copy link
Member

Deploying payu configurations would greatly benefit from CI checks to ensure configurations conform to some standards and avoid simple errors.

Code could be adapted from this repository which was designed to do these sorts of checks for ACCESS-OM2 experiment configurations

https://github.com/COSIMA/cleanconfig

The tests are contained here

https://github.com/COSIMA/cleanconfig/blob/master/test.py

They should be fairly self-explanatory and are mostly designed to ensure model configurations are portable and useable by everyone.

@aidanheerdegen aidanheerdegen added type:feature New feature or request priority:medium A medium priority issue - has some impact on functionality labels Nov 16, 2023
@aidanheerdegen
Copy link
Member Author

aidanheerdegen commented Feb 6, 2024

It probably makes sense to retain the checks as python scripts in the repo, as there is some path checking stuff which would be a pain to do in bash.

Edit: but this would require a python install ...

@aidanheerdegen
Copy link
Member Author

I would also like to add checks to make sure we have

reproduce:
   exe: True
   input: True

set in config.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:medium A medium priority issue - has some impact on functionality type:feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant