Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually add auto-generated MOM_parameter_doc.* for comprehensive documentation #74

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

minghangli-uni
Copy link

Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @minghangli-uni. Ideally these will be automatically generated, so we don't have to stay on top of generating them, but I guess this will have to do for now. But I think we should move these into a docs subdirectory so that it's clear they are not part of the configuration.

Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @minghangli-uni. LGTM (note I haven't actually checked that the parameter docs are correct for the configuration)

@minghangli-uni
Copy link
Author

Thanks @dougiesquire. These log files are not used by the MOM6, hence even if they lack some parameters from MOM_input (this bug), they will not affect our results. I will monitor the changes throughout the process, so rest assured.

@minghangli-uni minghangli-uni merged commit 32d084c into 025deg_jra55do_ryf Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants