Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 025deg_jra55_ryf_bgc for WOMBAT sea-ice coupling bug-fix #126

Merged
merged 8 commits into from
Jul 10, 2024

Conversation

dougiesquire
Copy link
Collaborator

@dougiesquire dougiesquire commented Jul 3, 2024

See #127 for details

@CodeGat
Copy link
Contributor

CodeGat commented Jul 3, 2024

@dougiesquire although it's weird that it's considering adding a commit that already exists on the remote (different hashes, though...) it would essentially be a no-op

Copy link

github-actions bot commented Jul 3, 2024

❌ The Bitwise Reproducibility check failed when comparing against `` for this Release config. ❌
For further information, the experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om2-configs/dev-025deg_jra55_ryf_bgc, and the test results at https://github.com/ACCESS-NRI/access-om2-configs/runs/26972807275.
You must bump the major version of this configuration before this PR is merged to account for this - to bump the version, comment `!bump major`or modify the `version` in `metadata.yaml`. The meaning of these version bumps is explained in the README.md, under `Config Tags`.

@dougiesquire dougiesquire changed the title Update 025deg_jra55_ryf_bgc for WOMBAT sea-ice coupling bug-fix and compiler+dependency updates Update 025deg_jra55_ryf_bgc for WOMBAT sea-ice coupling bug-fix Jul 9, 2024
@CodeGat
Copy link
Contributor

CodeGat commented Jul 9, 2024

Disregard this check. It was as a result of rebasing the dev-* onto release-*

Copy link

github-actions bot commented Jul 9, 2024

❌ The Bitwise Reproducibility check failed when comparing against release-025deg_jra55_ryf_bgc-2.0 for this Release config. ❌
For further information, the experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om2-configs/dev-025deg_jra55_ryf_bgc, and the test results at https://github.com/ACCESS-NRI/access-om2-configs/runs/27242738354.
You must bump the major version of this configuration before this PR is merged to account for this - to bump the version, comment !bump majoror modify the version in metadata.yaml. The meaning of these version bumps is explained in the README.md, under Config Tags.

…-patch

Update exes to latest release: `025deg_jra55_ryf_bgc`
Copy link

github-actions bot commented Jul 9, 2024

❌ The Bitwise Reproducibility check failed when comparing against release-025deg_jra55_ryf_bgc-2.0 for this Release config. ❌
For further information, the experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om2-configs/dev-025deg_jra55_ryf_bgc, and the test results at https://github.com/ACCESS-NRI/access-om2-configs/runs/27243481865.
You must bump the major version of this configuration before this PR is merged to account for this - to bump the version, comment !bump majoror modify the version in metadata.yaml. The meaning of these version bumps is explained in the README.md, under Config Tags.

@dougiesquire
Copy link
Collaborator Author

I think the failures here are as expected. We know that the bgc configs are currently not restart reproducible. The historical checksums differ only for the WOMBAT tracers, which makes sense because WOMBAT has changed.

$ wget https://raw.githubusercontent.com/ACCESS-NRI/access-om2-configs/f28504ed7782211b7309ee416ffd9b574f6d93d2/testing/checksum/historical-3hr-checksum.json -O historical-3hr-checksum.json.orig
$ diff -U2 historical-3hr-checksum.json.orig /scratch/tm70/repro-ci/experiments/access-om2-configs/dev-025deg_jra55_ryf_bgc/checksum/historical-3hr-checksum.json
--- historical-3hr-checksum.json.orig	2024-07-10 10:19:06.861573000 +1000
+++ /scratch/tm70/repro-ci/experiments/access-om2-configs/dev-025deg_jra55_ryf_bgc/checksum/historical-3hr-checksum.json2024-07-10 09:42:54.000000000 +1000
@@ -148,32 +148,32 @@
     ],
     "adic": [
-      "-2455395460635865998"
+      "-2455395406223065760"
     ],
     "caco3": [
-      "-1946311099822526178"
+      "-1946001330455210348"
     ],
     "alk": [
-      "666550672134593837"
+      "666550666703468188"
     ],
     "dic": [
-      "-8109352984002592935"
+      "-8109352923411889020"
     ],
     "no3": [
-      "7992606673146220590"
+      "-3927355164901111661"
     ],
     "phy": [
-      "-8977775330410481366"
+      "-5332833466290796183"
     ],
     "o2": [
-      "-2977305693613054852"
+      "-2977306008655971539"
     ],
     "fe": [
-      "-8926867780862610659"
+      "-8926870080351100871"
     ],
     "zoo": [
-      "3652579702518992198"
+      "3652619569480272960"
     ],
     "det": [
-      "-1773221676325612934"
+      "-1771932541263243583"
     ],
     "age_global": [

@dougiesquire
Copy link
Collaborator Author

!bump major

Copy link

❌ Failed to bump VERSION or commit changes, see https://github.com/ACCESS-NRI/access-om2-configs/actions/runs/9866119810

@CodeGat
Copy link
Contributor

CodeGat commented Jul 10, 2024

!bump major

Copy link

❌ Failed to bump VERSION or commit changes, see https://github.com/ACCESS-NRI/access-om2-configs/actions/runs/9866828779

@CodeGat
Copy link
Contributor

CodeGat commented Jul 10, 2024

!bump major

Copy link

✅ Version bumped from 2.0 to 3.0

@dougiesquire dougiesquire merged commit 8108aec into release-025deg_jra55_ryf_bgc Jul 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants