Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor parse_access_* functions into BaseBuilder class #181

Merged
merged 11 commits into from
Aug 19, 2024
Merged

Refactor parse_access_* functions into BaseBuilder class #181

merged 11 commits into from
Aug 19, 2024

Commits on Aug 1, 2024

  1. Preparatory step - add kwargs to parse_access_filename

    @marc-white
    marc-white committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b1ef81c View commit details
    Browse the repository at this point in the history

  2. Make parse_access_* be classmethods on BaseBuilder

    @marc-white
    marc-white committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    1a78c83 View commit details
    Browse the repository at this point in the history

  3. Update tests for latest changes; show pytest-cov output on terminal 

    (and curse VSCode for not saving things automatically like my last IDE)
    @marc-white
    marc-white committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    b7ce1c0 View commit details
    Browse the repository at this point in the history

  4. Refactor how the pattern 'helpers' are stored

    @marc-white
    marc-white committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    6c0cfca View commit details
    Browse the repository at this point in the history

  5. Completed reformat to parse_access_* being classmethods on builders, … 

    …including tests

(some cleanup still required)
    @marc-white
    marc-white committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    124ecd6 View commit details
    Browse the repository at this point in the history

  6. Remove terminal pytest-cov output

    @marc-white
    marc-white committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    1011f4e View commit details
    Browse the repository at this point in the history

  7. 'black' affected files

    @marc-white
    marc-white committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    607ccb5 View commit details
    Browse the repository at this point in the history

  8. Attempting to fix 'pre-commit' failure

    @marc-white
    marc-white committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    3049ed0 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Fix mistake in returning patterns to kwargs

    @marc-white
    marc-white committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    eae1916 View commit details
    Browse the repository at this point in the history

  2. Remove commented-out patterns

    @marc-white
    marc-white committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    0d8b8a1 View commit details
    Browse the repository at this point in the history

  3. Pre-commit test

    @marc-white
    marc-white committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    8465fb7 View commit details
    Browse the repository at this point in the history