-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default to a "latest" version? #191
Comments
This sounds like an eminently sensible idea. I can think of a few ways to do this in practice:
There are a few questions around any implementation:
|
The default catalog version is defined here. As you can see it is set to the As above, I propose changing the default catalog version to "latest", and have a version To answer your questions:
$ ls -alh /g/data/xp65/public/apps/access-nri-intake-catalog
total 36K
drwxrwsr-x+ 9 ds0092 xp65_w 4.0K May 7 08:56 .
drwxr-sr-x 8 rb5533 xp65 4.0K Aug 28 15:07 ..
drwxrwsr-x+ 3 ds0092 xp65_w 4.0K Sep 29 2023 v0.0.10
drwxrwsr-x+ 3 ds0092 xp65_w 4.0K Jul 10 2023 v0.0.8
drwxrwsr-x+ 3 ds0092 xp65_w 4.0K Jul 20 2023 v0.0.9
drwxrwsr-x+ 3 ds0092 xp65_w 4.0K Nov 29 2023 v0.1.0
drwxrwsr-x+ 3 ds0092 xp65_w 4.0K Mar 4 2024 v0.1.1
drwxrwsr-x+ 3 ds0092 xp65_w 4.0K Mar 28 14:12 v0.1.2
drwxrwsr-x+ 3 ds0092 xp65_w 4.0K Aug 29 16:54 v0.1.3 but we could probably ditch the
Reproducibility is one reason. It means users can be confident they are opening the same data (even if new data has since been added to the catalog). Also, if there's an issue with the latest catalog version it's convenient to be able to quickly switch to an earlier, working version. |
See, this is why I shouldn't blast through suggestions quickly when I'm tired... Do you envisage updating the code so it can intelligently work out if the symlink to 'latest' needs to be updated when a new catalog version is generated, or do you expect that to be a manual step that someone needs to jump into the filesystem to do? |
We could just remove the old symlink and create the new one as the final step in the build process? |
That's viable, although you'd need to be certain you were always creating a new catalog version, and not repairing an older catalog (or providing an small update to an existing catalog that's behind the 'latest' for whatever reason). |
The ACCESS-NRI Intake catalog is versioned in the same way as the
access-nri-intake
package (see/g/data/xp65/public/apps/access-nri-intake-catalog
).The default version is equal to the version of
access-nri-intake
being used, though the version can be specified when the catalog is loaded, e.g.This default behaviour ensures that the catalog version and the version of
access-nri-intake
being used are compatible. However, it also means that users with old versions ofaccess-nri-intake
installed won't use the most recent version of the catalog by default.We should consider instead defaulting to a "latest" version of the catalog that symlinks to the most recent released version. To manage compatibility issues, we could have "latest" versions for each major release (e.g.
latest_v1
) and ensure we increment the major version when changes are introduced toaccess-nri-intake
that break compatibility with old catalogs.The text was updated successfully, but these errors were encountered: