Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACCESS-OM3 filename patterns are too prescriptive #176

Open
anton-seaice opened this issue Jul 16, 2024 · 1 comment · May be fixed by #178
Open

ACCESS-OM3 filename patterns are too prescriptive #176

anton-seaice opened this issue Jul 16, 2024 · 1 comment · May be fixed by #178
Assignees
Labels
bug Something isn't working

Comments

@anton-seaice
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

For ESM1.5 and OM2, cice daily output is concatenated into a monthly files, with filenames containing -YYYY-MM-daily.nc

Currently, the OM3 builder accepts filenames of this form (e.g. om3.cice.h.1900-01-daily.nc), however the resulting datastore doesn't work. There is a new file_id in the datastore for each file, when there should be one for all daily cice data (I believe?)

Describe the feature you'd like

The regexs used to determine these fileid's needs revisiting:

rf"[^\.]*\.{om3_components}\..*({ymds}|{ymd}|{ym})$", # ACCESS-OM3

Describe alternatives you've considered

We could use a different form of the filename for daily cice output

Additional context

This is needed to add auto post-processing to OM3 configurations (COSIMA/access-om3#182).

To reproduce the error, see https://github.com/anton-seaice/sandbox/blob/main/open_datastore_after_cice_concat.ipynb

@anton-seaice anton-seaice added the enhancement New feature or request label Jul 16, 2024
@anton-seaice anton-seaice added bug Something isn't working and removed enhancement New feature or request labels Jul 16, 2024
@dougiesquire
Copy link
Collaborator

Thanks @anton-seaice. The approach of using regexes to determine the fileid for concatenation is obscure and error-prone and needs revisiting. I don't think any of us have time for that just now. Let's discuss this at the TWG meeting and we can add a quick fix if we decide to stick with the om3.cice.h.1900-01-daily.nc naming

@dougiesquire dougiesquire linked a pull request Jul 22, 2024 that will close this issue
@marc-white marc-white self-assigned this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants