Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MOM5 WOMBAT Fix without Dependency Update #16

Closed
wants to merge 5 commits into from
Closed

MOM5 WOMBAT Fix without Dependency Update #16

wants to merge 5 commits into from

Conversation

CodeGat
Copy link
Contributor

@CodeGat CodeGat commented Jul 5, 2024

In this PR:

  • Revert the Dependency Update (and old WOMBAT update)
  • Update the version of MOM5 to the WOMBAT fix version
  • Update versions of spack-packages/spack-config to avoid hdf5 bug
  • Removed versions.schema.json as schema is stored in ACCESS-NRI/schema
  • Update modulefile to only autoload: run rather than direct

Closes #7 (again!)

@CodeGat
Revert both "Merge pull request #11 from ACCESS-NRI/dougiesquire/issu…
1987f64 
…e8" and "Update MOM5 to include ice-ocean BGC coupling bug fix (#12)"

This reverts commit 1d521f0, reversing
changes made to 92ae023.
This also reverts commit 2cf4904.
@CodeGat
Deleted versions.schema.json, updated spack-packages 2024.07.03, spac…
7b2d443 
…k-config 2024.07.05
@CodeGat
Updated mom5 2024.06.27 (wombat fix), updated model version 2024.07.0…
e1dcce7 
…, updated formatting, made compiler version/target required
@CodeGat CodeGat requested a review from dougiesquire July 5, 2024 05:56
@CodeGat CodeGat self-assigned this Jul 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

🚀 Deploying access-om2-bgc 2024.07.0 as prerelease pr16-4

Details and usage instructions

This access-om2-bgc model will be deployed as:

  • 2024.07.0 as a Release (when merged).
  • pr16-4 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules/access-models/
module load access-om2-bgc/pr16-4

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.21/spack in the access-om2-bgc-pr16-4 environment.

🛠️ Using: spack-packages `2024.07.03`, spack-config `2024.07.05`
Details

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 5, 2024

🚀 Deploying access-om2-bgc 2024.07.0 as prerelease pr16-5

Details and usage instructions

This access-om2-bgc model will be deployed as:

  • 2024.07.0 as a Release (when merged).
  • pr16-5 as a Prerelease (during this PR).

This Prerelease is accessible on Gadi using:

module use /g/data/vk83/prerelease/modules/access-models/
module load access-om2-bgc/pr16-5

where the binaries shall be on your $PATH.
This Prerelease is also accessible on Gadi via /g/data/vk83/prerelease/apps/spack/0.21/spack in the access-om2-bgc-pr16-5 environment.

🛠️ Using: spack-packages `2024.07.06`, spack-config `2024.07.05`
Details

It will be deployed using:

If this is not what was expected, commit changes to config/versions.json.

@CodeGat
Copy link
Contributor Author

CodeGat commented Jul 7, 2024

Closing this as we do not need a MOM5 fix without dependency update because @dougiesquire has found the cause of the slowdown in #14

@CodeGat CodeGat closed this Jul 7, 2024
@CodeGat CodeGat removed the request for review from dougiesquire July 7, 2024 23:51
@CodeGat CodeGat mentioned this pull request Jul 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CodeGat CodeGat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New release with WOMBAT coupling bug fix
1 participant
@CodeGat