New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

websocket subscribe missing header bugfix #3383

Merged

StevenACoffman merged 1 commit into 99designs:master from jeremylaier-tc:ws-header-fix

Nov 22, 2024

Contributor

jeremylaier-tc commented Nov 21, 2024

Make serving requests from websockets, the headers of the request are being lost along the function chain.

This PR adds them back along so that the server is able to access the request headers via the

graphql.GetOperationContext(ctx) method

I have:

Added tests covering the bug / feature (see testing)
Updated any relevant documentation (see docs)


          ws fix

7632bbb

jeremylaier-tc changed the title ~~websocket header bugfix~~ websocket subscribe missing header bugfix

coveralls commented Nov 22, 2024

coverage: 59.587% (-0.01%) from 59.601%
when pulling 7632bbb on jeremylaier-tc:ws-header-fix
into 1040b92 on 99designs:master.

StevenACoffman merged commit 95ff723 into 99designs:master

16 of 17 checks passed

jeremylaier-tc deleted the ws-header-fix branch

November 24, 2024 21:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet