Skip to content

Commit

Permalink
chore: update golangci-lint to v1.62.0
Browse files Browse the repository at this point in the history
  • Loading branch information
alexandear committed Nov 24, 2024
1 parent de7923e commit e9987e9
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ concurrency:
jobs:
golangci-lint:
env:
GOLANGCI_LINT_VERSION: v1.60.2
GOLANGCI_LINT_VERSION: v1.62.0
strategy:
matrix:
go: ["1.22", "1.23"]
Expand Down
2 changes: 2 additions & 0 deletions codegen/testserver/followschema/directive_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ func TestDirectives(t *testing.T) {
srv := handler.NewDefaultServer(NewExecutableSchema(Config{
Resolvers: resolvers,
Directives: DirectiveRoot{
//nolint:revive // can't rename min, max because it's generated code
Length: func(ctx context.Context, obj any, next graphql.Resolver, min int, max *int, message *string) (any, error) {
e := func(msg string) error {
if message == nil {
Expand All @@ -133,6 +134,7 @@ func TestDirectives(t *testing.T) {
}
return res, nil
},
//nolint:revive // can't rename min, max because it's generated code
Range: func(ctx context.Context, obj any, next graphql.Resolver, min *int, max *int) (any, error) {
res, err := next(ctx)
if err != nil {
Expand Down
2 changes: 2 additions & 0 deletions codegen/testserver/singlefile/directive_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ func TestDirectives(t *testing.T) {
srv := handler.NewDefaultServer(NewExecutableSchema(Config{
Resolvers: resolvers,
Directives: DirectiveRoot{
//nolint:revive // can't fix min, max because it's generated code
Length: func(ctx context.Context, obj any, next graphql.Resolver, min int, max *int, message *string) (any, error) {
e := func(msg string) error {
if message == nil {
Expand All @@ -133,6 +134,7 @@ func TestDirectives(t *testing.T) {
}
return res, nil
},
//nolint:revive // can't rename min, max because it's generated code
Range: func(ctx context.Context, obj any, next graphql.Resolver, min *int, max *int) (any, error) {
res, err := next(ctx)
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions handler/handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@ func WebsocketUpgrader(upgrader websocket.Upgrader) Option {
}

// Deprecated: switch to graphql/handler.New
func RecoverFunc(recover graphql.RecoverFunc) Option {
func RecoverFunc(recoverFn graphql.RecoverFunc) Option {
return func(cfg *Config) {
cfg.recover = recover
cfg.recover = recoverFn
}
}

Expand Down

0 comments on commit e9987e9

Please sign in to comment.