Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing COMBO Primitive #108

Open
thinkingjimmy opened this issue Jan 16, 2024 · 2 comments
Open

Missing COMBO Primitive #108

thinkingjimmy opened this issue Jan 16, 2024 · 2 comments
Assignees
Labels
feature New feature request
Milestone

Comments

@thinkingjimmy
Copy link
Collaborator

Image

@thinkingjimmy
Copy link
Collaborator Author

I think ComfyUI's primitive is a better experience than ours, and they only have one. We, on the other hand, let the user choose

@6174
Copy link
Owner

6174 commented Jan 16, 2024

ComfyUI 's primitive node design is not a good pattern for the editor architecture, it is dynamic , the same with reroute node. For now I just create static primitive type (And I think it's better if I understand what type I need).

And combo primitive is weird in design pattern, I don't think it is a primitive type.

@thinkingjimmy thinkingjimmy modified the milestones: Alpha-004, Alpha-005 Jan 20, 2024
@thinkingjimmy thinkingjimmy modified the milestones: Alpha-005, Alpha-006 Jan 29, 2024
@6174 6174 modified the milestones: Alpha-006, Alpha-0.0.7 Feb 4, 2024
@thinkingjimmy thinkingjimmy modified the milestones: Alpha-0.0.7, 0.1.0 Feb 29, 2024
@thinkingjimmy thinkingjimmy moved this from Todo to In Review in Comflowyspace Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
Status: In Review
Development

No branches or pull requests

2 participants