Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is an attempt to have the
higlass
dependency andHiGlassPlainContainer
component live in SPC (here) rather than the CGAP and 4DN repos, individually.There is a roadblock to this currently in that HiGlass requires React-Bootstrap v0.32.4, while CGAP and 4DN are now on React-Bootstrap v1+. When HiGlass exists as dependency of either CGAP or 4DN, a copy of v0.32.4 is included along with it a sub-dependency and co-exists with v1+. However, when it is here, during development at least, since React-Bootstrap is a peer dependency, a symlink is created from SPC/node_modules/ to either 4DN or CGAP's React-Bootstrap library causing HiGlass to error as it isn't getting the right version of React-Bootstrap.
More research is needed on how to handle this issue. We could potentially wait for HiGlass to update to React-Boostrap v1+ - but then there is no guarantee the React-Bootstrap minor version used by HiGlass will always match the one used by CGAP and 4DN either and there might be issues due to this down the road as well.
For time being, HiGlass should live as a direct dependency of CGAP and 4DN repo (?).
More Thoughts
(please append more here or in comments if any)
setup-npm-links-for-local-development.js
also...