Ability to disable "Special Use Domain Name" blocking

[mapl]

No description provided.

[kwitsch]

There should be a warning included that this should only be done if your upstream DNS server is local since this shouldldn't be disabled for remote upstreams.

[mapl]

Add a warning as desired

[mapl]

I am not sure about the failed unit test. Please give me a hint there.

[kwitsch]

I am not sure about the failed unit test. Please give me a hint there.

Have only skimmed over the changes since I'm on mobile but it seems like you never set the enabled config option to false before checking if it's disabled.

[mapl]

I hope I fixed the unit test now

[codecov]

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.91%. Comparing base (fe84ab8) to head (e6c14f8).
Report is 145 commits behind head on main.

Files with missing lines	Patch %	Lines
resolver/sudn_resolver.go	0.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1618      +/-   ##
==========================================
+ Coverage   93.88%   93.91%   +0.02%     
==========================================
  Files          78       80       +2     
  Lines        6361     6569     +208     
==========================================
+ Hits         5972     6169     +197     
- Misses        300      316      +16     
+ Partials       89       84       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kwitsch]

I hope I fixed the unit test now

Fixed 🙂👍

Only one test is still missing: you test the enabled state for the config but not the resolver. The sudn resolver already has an option for disabling it for a subset. Those tests could be used as a starting point (an adaptation of the last sudn resolver test should be enough).

[mapl]

I added a test. Hopefully it works out. :)

[mapl]

I hope I fixed the unit test now

Fixed 🙂👍

Only one test is still missing: you test the enabled state for the config but not the resolver. The sudn resolver already has an option for disabling it for a subset. Those tests could be used as a starting point (an adaptation of the last sudn resolver test should be enough).

Anything more what I can do?